I never thought ordering of relational static fields and properties in C# mattered. And, then, I started getting NREs on a property I know was set to a static-instance…

The setup

public static void Main()
{
    Console.WriteLine(Person.Empty == null); // prints 'True'
}

public class Person
{
    public static readonly Person Empty = empty;

    private static readonly EmptyPerson empty = new EmptyPerson();
}

public sealed class EmptyPerson : Person { }

If you were to step-through the code, the first-time Person.Empty is called, empty is null and gets returned as-is. Then, empty is initialized. But, it’s too late since Empty is static and will only get “initialized” once. But, if we swap the ordering…

public class Person
{
    private static readonly EmptyPerson empty = new EmptyPerson();

    public static readonly Person Empty = empty;
}

Now, empty is an instance of EmptyPerson when Empty is called and everything is good.

Variations

The problem above is only a problem for static fields/properties. If either were to be an expression-member, then ordering doesn’t matter:

public class Person
{
    public static readonly Person Empty => empty;

    private static readonly EmptyPerson empty = new EmptyPerson();
}

// This variation also works...
public class Person
{
    public static readonly Person Empty = empty;

    private static readonly EmptyPerson empty => new EmptyPerson();
}

Then, there’s the obvious…

public class Person
{
    public static readonly Person Empty = new EmptyPerson();
}

But, I opted to use the private member in several other spots within my code…

But, don’t do this!

Just as a final warning, don’t do this because while you have a getter-only (i.e. readonly), you’ll also create a new instance of EmptyPerson every time Empty is called. 🤯

public class Person
{
    // Don't do this!
    public static Person Empty => new EmptyPerson();
}

Published Oct 9, 2019 by

CSS Only Tooltip for All Screen Sizes

Elasticsearch With NEST Using C# nameof Not Working

How to avoid NullReferenceException in C#

Getting Started Testing Vue Components

How ConveyUX Can Convey Good Ideas

Running Database Migrations On Web Application St...

Building ASP.NET Core 3.1 Apps To Organizational ...

What Works and What Doesn't With ConfigurationMan...

Regex Performance With and Without RegexOptions.C...

z-index Is Confusing, but It Doesn't Have to Be

Logging ASP.NET Web API 2 Failed Request Body to ...

Using forEach for IE 11

Understanding Dart Sass modules and namespaced va...

Autofac: Eager vs Lazy Construction During Regist...

Writing a Browser Compatible Date Input

Non Pro/Premier SendGrid Accounts May Have Issues...

Vue 3 Composition API

Upcoming Google Chrome SameSite Change Breaks Our...

A Case Of Newtonsoft.Json, TypeNameHandling.All, ...

Ordering of static fields in C# matters

The setup

Variations

Then, there’s the obvious…

But, don’t do this!

Comments

Ordering of static fields in C# matters

The setup

Variations

Then, there’s the obvious…

But, don’t do this!

How to avoid NullReferenceException in C#

Working With Nested Aggregates Using NEST and Elasticsearch

How To Check For Nulls In C# a.k.a. How To Thwart A Super Villian

Does A Property Exist On My C# Object

Comments